Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set a default database_connection_timeout #976

Closed
pjenvey opened this issue Jan 21, 2021 · 1 comment · Fixed by #995
Closed

Set a default database_connection_timeout #976

pjenvey opened this issue Jan 21, 2021 · 1 comment · Fixed by #995
Assignees
@pjenvey
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. bug Something isn't working

Comments

@pjenvey
Copy link
Member

pjenvey commented Jan 21, 2021

Follow up to #973: I did not add a proper set_default for this setting (of 30 seconds).
@pjenvey pjenvey added bug Something isn't working 1 Estimate - xs - This is a trivial change with clearly defined parameters. labels Jan 21, 2021
@pjenvey pjenvey self-assigned this Jan 21, 2021
pjenvey added a commit that referenced this issue Jan 21, 2021
@pjenvey
fix: downgrade deadpool so it stays on tokio 0.2
bee9ff9 
needed for its timer usage (when enabling connection timeouts)

and set a default connection timeout

Closes #977, #976
pjenvey added a commit that referenced this issue Jan 21, 2021
@pjenvey
fix: downgrade deadpool so it stays on tokio 0.2
99975ef 
needed for its timer usage (when enabling connection timeouts)

and set a default connection timeout

Closes #977, #976
@pjenvey pjenvey mentioned this issue Jan 21, 2021
Merged
@jrconlin
Copy link
Member

I'm presuming that this is OBE: https://github.com/mozilla-services/syncstorage-rs/blob/master/src/settings.rs#L84

@jrconlin jrconlin mentioned this issue Feb 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: tag 0.8.6 mozilla-services/syncstorage-rs
2 participants
@pjenvey @jrconlin