Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit metric for spanner DbPool::get time taken #952

Closed
pjenvey opened this issue Dec 16, 2020 · 0 comments · Fixed by #1044
Closed

Emit metric for spanner DbPool::get time taken #952

pjenvey opened this issue Dec 16, 2020 · 0 comments · Fixed by #1044
Assignees
@ethowitz
Labels
2 Estimate - s - This is a small change with clearly defined parameters. good first bug Low priority, but valuable contributions

Comments

@pjenvey
Copy link
Member

pjenvey commented Dec 16, 2020

Per #945, it's this may help show how quickly and when db pools become exhausted.
@pjenvey pjenvey added the 2 Estimate - s - This is a small change with clearly defined parameters. label Dec 16, 2020
@jrconlin jrconlin added the good first bug Low priority, but valuable contributions label Mar 15, 2021
@ethowitz ethowitz self-assigned this Apr 12, 2021
ethowitz pushed a commit that referenced this issue Apr 12, 2021
refactor: Emit metric for spanner DbPool::get time taken
9bff040 
Closes: #952
@ethowitz ethowitz mentioned this issue Apr 14, 2021
Merged
ethowitz added a commit that referenced this issue Apr 15, 2021
@ethowitz
refactor: Emit metric for spanner DbPool::get time taken (#1044)
57bd30a 
Closes: #952
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethowitz ethowitz

Labels
2 Estimate - s - This is a small change with clearly defined parameters. good first bug Low priority, but valuable contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor/952 add metric for spanner pool get mozilla-services/syncstorage-rs
3 participants
@pjenvey @jrconlin @ethowitz