Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SPANNER_EMULATOR_HOST #915

Closed
pjenvey opened this issue Nov 12, 2020 · 0 comments · Fixed by #1061
Closed

Support SPANNER_EMULATOR_HOST #915

pjenvey opened this issue Nov 12, 2020 · 0 comments · Fixed by #1061
Assignees
@ethowitz
Labels
2 Estimate - s - This is a small change with clearly defined parameters. enhancement New feature or request

Comments

@pjenvey
Copy link
Member

pjenvey commented Nov 12, 2020 •
edited
Loading

The Spanner emulator has built in support in all client libs. It's enabled via a SPANNER_EMULATOR_HOST env var.

We should support this (or SYNC_SPANNER_EMULATOR_HOST) and when enabled it would change SPANNER_ADDRESS to its value and setup an insecure grpc channel instad of the TLS connect.
@pjenvey pjenvey added enhancement New feature or request 2 Estimate - s - This is a small change with clearly defined parameters. labels Nov 12, 2020
ethowitz pushed a commit that referenced this issue Apr 30, 2021
feat: Support SYNC_SPANNER_EMULATOR_HOST
8324f86 
Closes #915
ethowitz pushed a commit that referenced this issue Apr 30, 2021
feat: Support SYNC_SPANNER_EMULATOR_HOST
add39d7 
Closes #915
@ethowitz ethowitz mentioned this issue Apr 30, 2021
Merged
@ethowitz ethowitz self-assigned this Apr 30, 2021
ethowitz added a commit that referenced this issue Apr 30, 2021
@ethowitz
feat: Support SYNC_SPANNER_EMULATOR_HOST (#1061)
322603a 
Closes #915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethowitz ethowitz

Labels
2 Estimate - s - This is a small change with clearly defined parameters. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Support SYNC_SPANNER_EMULATOR_HOST mozilla-services/syncstorage-rs
2 participants
@pjenvey @ethowitz