Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update quota to "non-enforce" mode. #870

Closed
jrconlin opened this issue Oct 21, 2020 · 0 comments · Fixed by #875
Closed

Update quota to "non-enforce" mode. #870

jrconlin opened this issue Oct 21, 2020 · 0 comments · Fixed by #875
Assignees
@jrconlin
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.

Comments

@jrconlin
Copy link
Member

A quota violation is logged, but no quota specific error is returned to the user.

Make sure that there is a metric reflecting the time of quota calculation per user and that the over quota error is logged to sentry.
@jrconlin jrconlin added the 3 Estimate - m - This is a small change, but there's some uncertainty. label Oct 21, 2020
jrconlin added a commit that referenced this issue Oct 26, 2020
@jrconlin
feat: Add SYNC_ENFORCE_QUOTA flag
f7979a7 
Adds `SYNC_ENFORCE_QUOTA` / `--enforce_quota` flag which will force an
error if a user exceeds quota.

So for the record:
    `SYNC_LIMITS__MAX_QUOTA_LIMIT` => Sets the quota limit (default 2GB)
    `SYNC_ENABLE_QUOTA` => Determine if quota calcs should be done
    `SYNC_ENFORCE_QUOTA` => Determine if over quota errors are returned

Closes #870
@jrconlin jrconlin mentioned this issue Oct 26, 2020
Merged
jrconlin added a commit that referenced this issue Oct 26, 2020
@jrconlin
feat: Add SYNC_ENFORCE_QUOTA flag
e9afa6d 
Adds `SYNC_ENFORCE_QUOTA` / `--enforce_quota` flag which will force an
error if a user exceeds quota.

So for the record:
    `SYNC_LIMITS__MAX_QUOTA_LIMIT` => Sets the quota limit (default 2GB)
    `SYNC_ENABLE_QUOTA` => Determine if quota calcs should be done
    `SYNC_ENFORCE_QUOTA` => Determine if over quota errors are returned

Closes #870
jrconlin added a commit that referenced this issue Nov 9, 2020
@jrconlin
feat: Add SYNC_ENFORCE_QUOTA flag (#875)
0e30801 
Adds `SYNC_ENFORCE_QUOTA` / `--enforce_quota` flag which will force an
error if a user exceeds quota.

So for the record:
    `SYNC_LIMITS__MAX_QUOTA_LIMIT` => Sets the quota limit (default 2GB)
    `SYNC_ENABLE_QUOTA` => Determine if quota calcs should be done
    `SYNC_ENFORCE_QUOTA` => Determine if over quota errors are returned
    `SYNC_LIMITS__MAX_RECORDS` => Upper max number of records we will attempt to fetch from the db.

Closes #870
jrconlin added a commit that referenced this issue Nov 9, 2020
@jrconlin
feat: Add SYNC_ENFORCE_QUOTA flag (#875)
8bcab13 
Adds `SYNC_ENFORCE_QUOTA` / `--enforce_quota` flag which will force an
error if a user exceeds quota.

So for the record:
    `SYNC_LIMITS__MAX_QUOTA_LIMIT` => Sets the quota limit (default 2GB)
    `SYNC_ENABLE_QUOTA` => Determine if quota calcs should be done
    `SYNC_ENFORCE_QUOTA` => Determine if over quota errors are returned
    `SYNC_LIMITS__MAX_RECORDS` => Upper max number of records we will attempt to fetch from the db.

Closes #870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
3 Estimate - m - This is a small change, but there's some uncertainty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add SYNC_ENFORCE_QUOTA flag mozilla-services/syncstorage-rs
1 participant
@jrconlin