Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.7.1 batch commit can exceed 20k max mutations #869

Closed
pjenvey opened this issue Oct 20, 2020 · 1 comment · Fixed by #877 or #881
Closed

0.7.1 batch commit can exceed 20k max mutations #869

pjenvey opened this issue Oct 20, 2020 · 1 comment · Fixed by #877 or #881
Assignees
@pjenvey
Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. bug Something isn't working p1 Stuff we gotta do before we ship!

Comments

@pjenvey
Copy link
Member

pjenvey commented Oct 20, 2020

Seen here:

https://sentry.prod.mozaws.net/operations/syncstorage-prod/issues/9820467/

Likely the changes for quota support (even when disabled) seem to have changed the batch commit's write pattern.
@pjenvey pjenvey added bug Something isn't working p1 Stuff we gotta do before we ship! 5 Estimate - l - Moderately complex, will require some effort but clearly defined. labels Oct 20, 2020
@pjenvey
Copy link
Member Author

pjenvey commented Oct 20, 2020

It looks like batch commit originally called touch_collection_async to begin. Now it calls update_collection_async to begin instead, with an extra call to the new update_user_collection_quotas at the end.

The last time I calculated mutations there was little to no room for extras, so I'm guessing the new, additional update_user_collection_quotas call puts it over.

@pjenvey pjenvey self-assigned this Oct 23, 2020
pjenvey added a commit that referenced this issue Oct 29, 2020
@pjenvey
fix: avoid extra quota related work in batch commit
51c3bda 
and document batch commit's mutations

Closes #869
This was referenced Oct 29, 2020
Open
Merged
@jrconlin jrconlin mentioned this issue Oct 29, 2020
Merged
@pjenvey pjenvey mentioned this issue Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. bug Something isn't working p1 Stuff we gotta do before we ship!
Projects
None yet
Milestone
No milestone
1 participant
@pjenvey