Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement mysql backend for tokenserver route #864

Closed
fzzzy opened this issue Oct 19, 2020 · 0 comments · Fixed by #871
Closed

Implement mysql backend for tokenserver route #864

fzzzy opened this issue Oct 19, 2020 · 0 comments · Fixed by #871
Assignees
@fzzzy
Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. tokenserver

Comments

@fzzzy
Copy link
Contributor

fzzzy commented Oct 19, 2020

When we implement the tokenserver route in rust, we should support the same mysql backend schema as the old server. This will make migrations easier.
@fzzzy fzzzy added 5 Estimate - l - Moderately complex, will require some effort but clearly defined. tokenserver labels Oct 19, 2020
@fzzzy fzzzy self-assigned this Oct 19, 2020
@fzzzy fzzzy mentioned this issue Oct 19, 2020
Closed
@fzzzy fzzzy mentioned this issue Oct 21, 2020
Merged
fzzzy added a commit that referenced this issue Oct 21, 2020
@fzzzy
feature: Implement an initial tokenserver endpoint spike in the syncs…
61908d0 
…torage-rs codebase. Fix #864

Requires an existing tokenserver mysaql db.
fzzzy added a commit that referenced this issue Oct 26, 2020
@fzzzy
feature: Implement an initial tokenserver endpoint spike in the sync…
72cf6c3 
…storage-rs codebase. Fix #864

Requires an existing tokenserver mysql db.
@fzzzy fzzzy closed this as completed in #871 Nov 5, 2020
fzzzy added a commit that referenced this issue Nov 5, 2020
@fzzzy @pjenvey
feat: Implement rudimentary tokenserver route in syncstorage-rs (#871)
b74943e 
* feature: Implement an initial tokenserver endpoint spike in the syncstorage-rs codebase. Fix #864

Requires an existing tokenserver mysql db.

* Re-add Cargo.lock

* Clean up.

* Return the urrl with the uid and no trailing slash

Co-authored-by: Philip Jenvey <[email protected]>

* format such that flake8 shall not complain.

* Pretty-format the sql.

* Missed an AND

* Use r# for the sql string

* cargo fmt

* resolve conflicts

Co-authored-by: Philip Jenvey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzzzy fzzzy

Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. tokenserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Implement rudimentary tokenserver route in syncstorage-rs mozilla-services/syncstorage-rs
1 participant
@fzzzy