Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing builds with clippy errors against latest stable rust version. #850

Closed
tublitzed opened this issue Oct 8, 2020 · 0 comments · Fixed by #851 or #857
Closed

Failing builds with clippy errors against latest stable rust version. #850

tublitzed opened this issue Oct 8, 2020 · 0 comments · Fixed by #851 or #857
Assignees
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.

Comments

@tublitzed
Copy link
Contributor

tublitzed commented Oct 8, 2020

Ie, here

error: match expression looks like `matches!` macro
  --> src/db/tests/batch.rs:90:34
   |
90 |           ApiErrorKind::Db(dbe) => match dbe.kind() {
   |  __________________________________^
91 | |             DbErrorKind::BatchNotFound => true,
92 | |             _ => false,
93 | |         },
   | |_________^ help: try this: `matches!(dbe.kind(), DbErrorKind::BatchNotFound)`
   |
   = note: `-D clippy::match-like-matches-macro` implied by `-D warnings`
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: match expression looks like `matches!` macro
   --> src/db/transaction.rs:224:27
    |
224 |               let is_read = match method {
    |  ___________________________^
225 | |                 Method::GET | Method::HEAD => true,
226 | |                 _ => false,
227 | |             };
    | |_____________^ help: try this: `matches!(method, Method::GET | Method::HEAD)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro

error: aborting due to 2 previous errors

I'm wondering if it's worth changing our circle config from defaulting to rust stable to instead defaulting to the version of rust that we're using in the app?

@tublitzed tublitzed self-assigned this Oct 8, 2020
@tublitzed tublitzed added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label Oct 8, 2020
tublitzed added a commit that referenced this issue Oct 8, 2020
tublitzed added a commit that referenced this issue Oct 8, 2020
jrconlin pushed a commit that referenced this issue Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
None yet
1 participant