Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to run on macOS #774

Closed
tublitzed opened this issue Aug 10, 2020 · 1 comment · Fixed by #775
Closed

Unable to run on macOS #774

tublitzed opened this issue Aug 10, 2020 · 1 comment · Fixed by #775
Assignees
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.

Comments

@tublitzed
Copy link
Contributor

tublitzed commented Aug 10, 2020

Running make run yields the following:

cargo:rustc-link-search=native=/Users/tublitzed/aaarach/Codebase/GIT/syncstorage-rs/target/debug/build/libz-sys-153843b33fd7f4b5/out/lib
running: "cmake" "/Users/tublitzed/.cargo/registry/src/github.com-1ecc6299db9ec823/grpcio-sys-0.6.0/grpc" "-DgRPC_INSTALL=false" "-DgRPC_BUILD_CSHARP_EXT=false" "-DgRPC_BUILD_CODEGEN=false" "-DgRPC_BENCHMARK_PROVIDER=none" "-DgRPC_SSL_PROVIDER=package" "-DgRPC_ZLIB_PROVIDER=package" "-DCMAKE_INSTALL_PREFIX=/Users/tublitzed/aaarach/Codebase/GIT/syncstorage-rs/target/debug/build/grpcio-sys-0b3e427acdd6680a/out" "-DCMAKE_C_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64 -arch x86_64" "-DCMAKE_C_COMPILER=/usr/bin/cc" "-DCMAKE_CXX_FLAGS= -stdlib=libc++ -ffunction-sections -fdata-sections -fPIC -m64 -arch x86_64" "-DCMAKE_CXX_COMPILER=/usr/bin/c++" "-DCMAKE_ASM_FLAGS= -ffunction-sections -fdata-sections -fPIC -m64 -arch x86_64" "-DCMAKE_ASM_COMPILER=/usr/bin/cc" "-DCMAKE_BUILD_TYPE=Debug"
-- Configuring incomplete, errors occurred!
See also "/Users/tublitzed/aaarach/Codebase/GIT/syncstorage-rs/target/debug/build/grpcio-sys-0b3e427acdd6680a/out/build/CMakeFiles/CMakeOutput.log".
See also "/Users/tublitzed/aaarach/Codebase/GIT/syncstorage-rs/target/debug/build/grpcio-sys-0b3e427acdd6680a/out/build/CMakeFiles/CMakeError.log".

--- stderr
CMake Warning at cmake/protobuf.cmake:51 (message):
  gRPC_PROTOBUF_PROVIDER is "module" but PROTOBUF_ROOT_DIR is wrong
Call Stack (most recent call first):
  CMakeLists.txt:207 (include)


CMake Error at /usr/local/Cellar/cmake/3.18.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:165 (message):
  Could NOT find OpenSSL, try to set the path to OpenSSL root folder in the
  system variable OPENSSL_ROOT_DIR (missing: OPENSSL_INCLUDE_DIR)
Call Stack (most recent call first):
  /usr/local/Cellar/cmake/3.18.1/share/cmake/Modules/FindPackageHandleStandardArgs.cmake:458 (_FPHSA_FAILURE_MESSAGE)
  /usr/local/Cellar/cmake/3.18.1/share/cmake/Modules/FindOpenSSL.cmake:486 (find_package_handle_standard_args)
  cmake/ssl.cmake:66 (find_package)
  CMakeLists.txt:208 (include)

Looks like a revert on this addition should resolve, but that breaks things for ubuntu so we should find another way to address this.

@tublitzed tublitzed self-assigned this Aug 10, 2020
@tublitzed tublitzed added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label Aug 10, 2020
@jrconlin
Copy link
Member

We believe that the issue is related to Cargo's Resolve function not being as clever as I hoped.
See rust-lang/cargo#1197
rust-lang/cargo#7914

Instead of using the target features, it is recommended that explict platform feature requirements be specifed via options to the cargo build.

e.g. cargo build --features grpcio/openssl or similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
None yet
2 participants