Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Last-Modified header missing from /info/configuration response in v0.5.3 #759

Closed
rfk opened this issue Aug 4, 2020 · 1 comment · Fixed by #761
Closed

X-Last-Modified header missing from /info/configuration response in v0.5.3 #759

rfk opened this issue Aug 4, 2020 · 1 comment · Fixed by #761
Assignees
Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. bug Something isn't working p1 Stuff we gotta do before we ship!

Comments

@rfk
Copy link
Contributor

rfk commented Aug 4, 2020

This is a spinoff from the discussion over in mozilla/application-services#3379.

On version 0.4.2 of syncstorage-rs (currently in production) the server includes an X-Last-Modified header in its response to the /info/configuration request. It's honestly kind of weird to include it on this particular request, because it's not really a part of the stored data that can be modified. But be that as it may, the api docs do say that this header "will be included in all success responses", and the Rust sync client code will error out if it is missing from any response.

On version 0.5.3 of syncstorage-rs (currently in stage) the server no longer seems to include an X-Last-Modified header in the response to this request. I'm not sure what changed, and it may only occur for new accounts, but it's currently preventing QA from testing syncing on stage, ref mozilla/application-services#3379 and mozilla-services/syncserver#221.

Could we please restore the X-Last-Modified header on all success responses?

@rfk
Copy link
Contributor Author

rfk commented Aug 10, 2020

Thanks folks! If possible, could you please comment here or in mozilla/application-services#3379 once this is deployed to stage, so that we can unlock QA of the mobile clients?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. bug Something isn't working p1 Stuff we gotta do before we ship!
Projects
None yet
3 participants