Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[purge-ttl] Consider using REGEXP_CONTAINS() for fxa_uid group matching #735

Closed
jrconlin opened this issue Jul 21, 2020 · 1 comment · Fixed by #776
Closed

[purge-ttl] Consider using REGEXP_CONTAINS() for fxa_uid group matching #735

jrconlin opened this issue Jul 21, 2020 · 1 comment · Fixed by #776
Assignees
@AzureMarker
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.

Comments

@jrconlin
Copy link
Member

see https://cloud.google.com/spanner/docs/functions-and-operators#regexp_contains

right now we do simple SQL like 'a%' for grouping. Unfortunately, spanner doesn't support ranges so like '[0-9]% won't work. They do provide REGEXP_CONTAINS(column, pattern) which would let us build ranges.
@jrconlin jrconlin added the 3 Estimate - m - This is a small change, but there's some uncertainty. label Jul 21, 2020
@jrconlin jrconlin self-assigned this Jul 21, 2020
@AzureMarker AzureMarker assigned AzureMarker and unassigned jrconlin Aug 10, 2020
@pjenvey
Copy link
Member

pjenvey commented Aug 10, 2020

Confirmed the BatchExpiry index will still be used with it:

Screen Shot 2020-08-10 at 2 34 32 PM

@AzureMarker AzureMarker mentioned this issue Aug 11, 2020
Merged
AzureMarker added a commit that referenced this issue Aug 11, 2020
@AzureMarker
feat: More purge_ttl features (#776)
59aa28a 
* Support a mode option in purge_ttl

* Support an expiry mode option in purge_ttl

* Support serially deleting prefixes by regex

Also changes the collection IDs option from a JSON list to an args list
(i.e. [item1,item2,item3]).

Closes #735
Closes #743
@jrconlin jrconlin mentioned this issue Aug 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzureMarker AzureMarker

Labels
3 Estimate - m - This is a small change, but there's some uncertainty.
Projects
None yet
Milestone
No milestone
3 participants
@pjenvey @jrconlin @AzureMarker