Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax the MAX_TTL restriction #480

Closed
pjenvey opened this issue Mar 11, 2020 · 2 comments
Closed

Relax the MAX_TTL restriction #480

pjenvey opened this issue Mar 11, 2020 · 2 comments
Labels
3 Estimate - m - This is a small change, but there's some uncertainty. bug Something isn't working p1 Stuff we gotta do before we ship!

Comments

@pjenvey
Copy link
Member

pjenvey commented Mar 11, 2020

We currently limit ttl to a max of 31_536_000, matching the original restriction in Python syncstorage.

It "temporarily" lifted this limit to work around a bug (see Issue 977397 / server-syncstorage#80b57eab but never restored it. Since then the forms engine began defaulting to a higher value.

Let's bump the value to at the very least forms' 3 years or some other agreed upon number.

The Sync 1.5 API states a max of 9 digits but that's significantly large (potentially > 31 years). If possible we should update the API doc with the a new max.

@pjenvey pjenvey added bug Something isn't working p1 Stuff we gotta do before we ship! 3 Estimate - m - This is a small change, but there's some uncertainty. labels Mar 11, 2020
@pjenvey
Copy link
Member Author

pjenvey commented Mar 11, 2020

Mark brought up a good point that the default TTL is a "forever" value of 2_100_000_000 (=~ 66 years) so maybe =~ 31 years doesn't matter much.

@tublitzed
Copy link
Contributor

For the record the diff where we changed the FORMS_TTL is here and happened 5 years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 Estimate - m - This is a small change, but there's some uncertainty. bug Something isn't working p1 Stuff we gotta do before we ship!
Projects
None yet
Development

No branches or pull requests

2 participants