Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert get_storage_usage and delete_storage to async await #453

Closed
fzzzy opened this issue Feb 27, 2020 · 1 comment · Fixed by #455
Closed

Convert get_storage_usage and delete_storage to async await #453

fzzzy opened this issue Feb 27, 2020 · 1 comment · Fixed by #455
Assignees
@fzzzy
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.

Comments

@fzzzy
Copy link
Contributor

fzzzy commented Feb 27, 2020

There were a few stragglers that were missed when converting everything else in the spanner db backend to async await.

  • get_storage_usage
  • delete_storage
@fzzzy fzzzy self-assigned this Feb 27, 2020
@fzzzy fzzzy added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label Feb 27, 2020
@fzzzy
Copy link
Contributor Author

fzzzy commented Feb 27, 2020

Also check

fzzzy added a commit that referenced this issue Feb 27, 2020
@fzzzy
refactor: Fix #453 Convert straggler functions to async await
69d50d2
@fzzzy fzzzy mentioned this issue Feb 27, 2020
Merged
fzzzy added a commit that referenced this issue Feb 27, 2020
@fzzzy
Merge pull request #455 from mozilla-services/453-convert-stragglers-…
c40c931 
…to-async-await

refactor: Fix #453 Convert straggler functions to async await
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzzzy fzzzy

Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Fix #453 Convert straggler functions to async await mozilla-services/syncstorage-rs
1 participant
@fzzzy