Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert database batch calls to async/await #435

Closed
fzzzy opened this issue Feb 13, 2020 · 2 comments · Fixed by #452
Closed

Convert database batch calls to async/await #435

fzzzy opened this issue Feb 13, 2020 · 2 comments · Fixed by #452
Assignees
@fzzzy
Labels
3 Estimate - m - This is a small change, but there's some uncertainty.

Comments

@fzzzy
Copy link
Contributor

fzzzy commented Feb 13, 2020 •
edited
Loading

  • create_batch
  • validate_batch
  • append_to_batch
  • get_batch
  • commit_batch
@fzzzy fzzzy mentioned this issue Feb 13, 2020
Closed
@fzzzy fzzzy added the 5 Estimate - l - Moderately complex, will require some effort but clearly defined. label Feb 20, 2020
@fzzzy fzzzy added 3 Estimate - m - This is a small change, but there's some uncertainty. and removed 5 Estimate - l - Moderately complex, will require some effort but clearly defined. labels Feb 24, 2020
@fzzzy fzzzy self-assigned this Feb 24, 2020
@fzzzy
Copy link
Contributor Author

fzzzy commented Feb 27, 2020 •
edited
Loading

Also delete_batch

@fzzzy
Copy link
Contributor Author

fzzzy commented Feb 27, 2020 •
edited
Loading

Also do_append
Also pretouch_collection

fzzzy added a commit that referenced this issue Feb 27, 2020
@fzzzy
refactor: Fix #435 Convert db batch calls to async await.
a9eeddb
@fzzzy fzzzy mentioned this issue Feb 27, 2020
Merged
fzzzy added a commit that referenced this issue Feb 27, 2020
@fzzzy
Merge pull request #452 from mozilla-services/435-convert-db-batch-ca…
c31929f 
…lls-to-async-await

refactor: Fix #435 Convert db batch calls to async await.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fzzzy fzzzy

Labels
3 Estimate - m - This is a small change, but there's some uncertainty.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Fix #435 Convert db batch calls to async await. mozilla-services/syncstorage-rs
1 participant
@fzzzy