Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the db-tests crate (reintegrate into main crate) #410

Closed
pjenvey opened this issue Jan 10, 2020 · 0 comments · Fixed by #465
Closed

Remove the db-tests crate (reintegrate into main crate) #410

pjenvey opened this issue Jan 10, 2020 · 0 comments · Fixed by #465
Assignees
@pjenvey
Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. cleanup

Comments

@pjenvey
Copy link
Member

pjenvey commented Jan 10, 2020 •
edited
Loading

Now that db-tests can run on stable, they no longer need to live in a separate crate.

Reintegrating them back into the main crate will simplify running the entire test suite (in dev and ci) and remove the need for the special db_test feature/cfg! attribute (and possibly even save us all some disk space sans db-tests/target).
@pjenvey pjenvey added cleanup 5 Estimate - l - Moderately complex, will require some effort but clearly defined. labels Jan 10, 2020
pjenvey added a commit that referenced this issue Mar 3, 2020
@pjenvey
test: move db-tests back into the main crate
2fb5877 
ISsue #410
pjenvey added a commit that referenced this issue Mar 3, 2020
@pjenvey
test: fixup db tests imports
dd1d651 
and remove db-test crate remnants

Issue #410
@pjenvey pjenvey mentioned this issue Mar 3, 2020
Merged
pjenvey added a commit that referenced this issue Mar 3, 2020
@pjenvey
test: kill the no longer needed db_test feature
63667d1 
Closes #410
jrconlin pushed a commit that referenced this issue Mar 3, 2020
@pjenvey
test: move db-tests back into the main crate (#465)
f699085 
* test: move db-tests back into the main crate
* test: fixup db tests imports and remove db-test crate remnants
* test: kill the no longer needed db_test feature

Closes #410
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
5 Estimate - l - Moderately complex, will require some effort but clearly defined. cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: move db-tests back into the main crate mozilla-services/syncstorage-rs
1 participant
@pjenvey