Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The storage.spanner.pool.get metric is inaccurate #406

Closed
pjenvey opened this issue Jan 9, 2020 · 1 comment
Closed

The storage.spanner.pool.get metric is inaccurate #406

pjenvey opened this issue Jan 9, 2020 · 1 comment
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.

Comments

@pjenvey
Copy link
Member

pjenvey commented Jan 9, 2020

This metric captures the time of the wrong place (in new vs get).
@pjenvey pjenvey added the 1 Estimate - xs - This is a trivial change with clearly defined parameters. label Jan 9, 2020
pjenvey added a commit that referenced this issue Apr 28, 2020
@pjenvey
feat: emit Db pool metrics periodically
eb3b8f8 
Closes #555, #406
pjenvey added a commit that referenced this issue Apr 29, 2020
@pjenvey
feat: emit Db pool metrics periodically
8991515 
kill the mislabeled pool get metric for now (fixes it repeatedly
emitting)

Closes #555, #406
@pjenvey pjenvey mentioned this issue Apr 29, 2020
Merged
pjenvey added a commit that referenced this issue May 4, 2020
@pjenvey
feat: emit Db pool metrics periodically (#605)
c3d6946 
kill the mislabeled pool get metric for now (fixes it repeatedly
emitting)

Closes #555, #406
pjenvey added a commit that referenced this issue May 4, 2020
@pjenvey
feat: emit Db pool metrics periodically (#605)
f5aefba 
kill the mislabeled pool get metric for now (fixes it repeatedly
emitting)

Closes #555, #406

(cherry picked from commit c3d6946)
pjenvey added a commit that referenced this issue May 5, 2020
@pjenvey
feat: emit Db pool metrics periodically (#605)
1761f7c 
kill the mislabeled pool get metric for now (fixes it repeatedly
emitting)

Closes #555, #406

(cherry picked from commit c3d6946)
@pjenvey
Copy link
Member Author

pjenvey commented May 28, 2020

This metric was completely removed in #605, so no longer applicable

@pjenvey pjenvey closed this as completed May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjenvey