Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the Tags Error and extractor passthru #403

Closed
pjenvey opened this issue Jan 8, 2020 · 0 comments · Fixed by #862 or #881
Closed

Remove the Tags Error and extractor passthru #403

pjenvey opened this issue Jan 8, 2020 · 0 comments · Fixed by #862 or #881
Assignees
@jrconlin
Labels
2 Estimate - s - This is a small change with clearly defined parameters. cleanup p1 Stuff we gotta do before we ship!

Comments

@pjenvey
Copy link
Member

pjenvey commented Jan 8, 2020

With the sentry middleware now gathering tags via the request/response extensions, we can remove the original API for this where Tags were passed around throughout extractors and ValidationErrors (to ultimately propagate them out to sentry). This should be a nice simplification/cleanup.

#372 (comment)
@pjenvey pjenvey added cleanup 2 Estimate - s - This is a small change with clearly defined parameters. labels Jan 8, 2020
@pjenvey pjenvey mentioned this issue Mar 6, 2020
Open
@pjenvey pjenvey added the p1 Stuff we gotta do before we ship! label Oct 5, 2020
@jrconlin jrconlin self-assigned this Oct 12, 2020
jrconlin added a commit that referenced this issue Oct 16, 2020
@jrconlin
feat: remove Tags handoffs
aaab6dd 
This removes the "Tags" struct from being passed around in various
calls. Instead the `sentry` mod pulls the `Tags` from the `extensions`
associated with either the request or response.

Closes #403
@jrconlin jrconlin mentioned this issue Oct 16, 2020
Merged
jrconlin added a commit that referenced this issue Oct 20, 2020
@jrconlin
feat: remove Tags handoffs
6336f25 
This removes the "Tags" struct from being passed around in various
calls. Instead the `sentry` mod pulls the `Tags` from the `extensions`
associated with either the request or response.

Closes #403
jrconlin added a commit that referenced this issue Oct 22, 2020
@jrconlin @tublitzed
feat: remove Tags handoffs (#862)
c6ea474 
feat: remove Tags handoffs

This removes the "Tags" struct from being passed around in various
calls. Instead the `sentry` mod pulls the `Tags` from the `extensions`
associated with either the request or response.

Closes #403

Co-authored-by: Rachel Tublitz <[email protected]>
@jrconlin jrconlin mentioned this issue Oct 29, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jrconlin jrconlin

Labels
2 Estimate - s - This is a small change with clearly defined parameters. cleanup p1 Stuff we gotta do before we ship!
Projects
None yet
Milestone
No milestone
2 participants
@pjenvey @jrconlin