Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve support code (as_value/as_list_value) #260

Closed
pjenvey opened this issue Oct 9, 2019 · 1 comment · Fixed by #1046
Closed

Improve support code (as_value/as_list_value) #260

pjenvey opened this issue Oct 9, 2019 · 1 comment · Fixed by #1046
Assignees
Labels
8 Estimate - xl - Moderately complex, medium effort, some uncertainty. cleanup

Comments

@pjenvey
Copy link
Member

pjenvey commented Oct 9, 2019

Looking forward a bit into an improved high level Spanner client, our as_value and as_list_value methods could be improved.

They provided an easy way to support both client sdks simultaneously, but we could improve how types are converted to protobuf Values via a trait, similar to diesel's ToSql trait.

Say a ToSpannerValue trait with impls for basic types like String, i32 (and in our specific case, SyncTimestamp). And an impl for either Vec<V> or possibly a fancy one like T: where T: Iterator<Item=V> (both where V: ToSpannerValue) if possible

@pjenvey pjenvey added the cleanup label Oct 9, 2019
@pjenvey pjenvey added the 8 Estimate - xl - Moderately complex, medium effort, some uncertainty. label Mar 6, 2020
@pjenvey
Copy link
Member Author

pjenvey commented Mar 6, 2020

Maybe less than an 8 score technically but there's some uncertainty on how this will all work

@ethowitz ethowitz self-assigned this Apr 15, 2021
ethowitz pushed a commit that referenced this issue Apr 16, 2021
ethowitz pushed a commit that referenced this issue Apr 16, 2021
ethowitz pushed a commit that referenced this issue Apr 16, 2021
ethowitz added a commit that referenced this issue Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8 Estimate - xl - Moderately complex, medium effort, some uncertainty. cleanup
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants