Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from mariadb libmysqlclient to mysql's #1434

Closed
data-sync-user opened this issue Nov 1, 2022 · 0 comments · Fixed by #1435
Closed

Switch from mariadb libmysqlclient to mysql's #1434

data-sync-user opened this issue Nov 1, 2022 · 0 comments · Fixed by #1435
Assignees
@pjenvey

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Nov 1, 2022 •
edited
Loading

mariadb’s libmysqlclient doesn’t support TLS by default, whereas the mysql impl does.

┆Issue is synchronized with this Jira Task
pjenvey added a commit that referenced this issue Nov 1, 2022
@pjenvey
chore: switch from mariadb libmysqlclient to mysql's
d51b676 
as it defaults to TLS connections and has generally better TLS support than
mariadb's (e.g. the common MYSQL_OPT_SSL_MODE is specific to mysql's impl)

Closes #1434
pjenvey added a commit that referenced this issue Nov 1, 2022
@pjenvey
chore: switch from mariadb libmysqlclient to mysql's
871912f 
as it defaults to TLS connections and has generally better TLS support than
mariadb's (e.g. the common MYSQL_OPT_SSL_MODE is specific to mysql's impl)

Closes #1434
pjenvey added a commit that referenced this issue Nov 1, 2022
@pjenvey
chore: switch from mariadb libmysqlclient to mysql's
62d0034 
as it defaults to TLS connections. also diesel's ssl_mode relies on the mysql
specific MYSQL_OPT_SSL_MODE option

Closes #1434
@pjenvey pjenvey mentioned this issue Nov 1, 2022
Merged
pjenvey added a commit that referenced this issue Nov 1, 2022
@pjenvey
chore: switch from mariadb libmysqlclient to mysql's
9d6166f 
as it defaults to TLS connections. also diesel's ssl_mode relies on the mysql
specific MYSQL_OPT_SSL_MODE option

Closes #1434
@pjenvey pjenvey closed this as completed in b4fe184 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjenvey pjenvey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: switch from mariadb libmysqlclient to mysql's mozilla-services/syncstorage-rs
2 participants
@pjenvey @data-sync-user