Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Tokenserver's token_verification metric with BrowserID vs OAuth #1358

Closed
data-sync-user opened this issue Jul 12, 2022 · 0 comments · Fixed by #1359
Closed

Tag Tokenserver's token_verification metric with BrowserID vs OAuth #1358

data-sync-user opened this issue Jul 12, 2022 · 0 comments · Fixed by #1359

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Jul 12, 2022

Tokenserver emits a syncstorage.tokenserver.token_verification metric that reports the amount of time in milliseconds it took to verify a token (be it an OAuth token or BrowserID assertion). OAuth tokens and BrowserID assertions are verified very differently, with OAuth tokens verified locally and BrowserID assertions requiring a request to FxA, which makes the performance of each of these operations rather different. As it exists today, the metric only provides timing statistics about OAuth and BrowserID verification in aggregate. It would be beneficial for characterizing Tokenserver’s performance under production conditions to tag this metric so we have visibility into token verification performance for BrowserID and OAuth separately.

┆Issue is synchronized with this Jira Task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant