Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add settings crates #1276

Closed
data-sync-user opened this issue Apr 7, 2022 · 0 comments · Fixed by #1306
Closed

Add settings crates #1276

data-sync-user opened this issue Apr 7, 2022 · 0 comments · Fixed by #1306
Labels
sync-modernization

Comments

@data-sync-user
Copy link
Collaborator

data-sync-user commented Apr 7, 2022 •
edited
Loading

Add the following crates (they should be independent from each other):

  • syncstorage-settings: code related to syncstorage settings
  • tokenserver-settings: code related to Tokenserver settings

Currently, the Tokenserver settings are nested within the Syncstorage settings. Ideally, we should remove this dependency relationship so that Syncstorage and Tokenserver can be run independently from one-another.

┆Issue is synchronized with this Jira Task
@ethowitz ethowitz mentioned this issue May 9, 2022
Merged
@ethowitz ethowitz mentioned this issue Sep 30, 2022
Merged
ethowitz added a commit that referenced this issue Oct 19, 2022
@ethowitz
refactor: add settings crates (#1306)
0ae5fd2 
This is a breaking change. This commit separates syncstorage and tokenserver settings into separate structs that are contained by a parent `Settings` struct. This means that any env vars that hold settings specific to syncstorage (e.g. `SYNC_DATABASE_URL`) have been renamed to `SYNC_SYNCSTORAGE__DATABASE_URL`. Any settings that were moved from the top-level `Settings` struct to the lower level, syncstorage-specific struct will now have a `SYNC_SYNCSTORAGE__` prefix instead of a `SYNC_` prefix.

Closes #1276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sync-modernization
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: add settings crates mozilla-services/syncstorage-rs
2 participants
@ethowitz @data-sync-user