Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add BrowserID support to Tokenserver #1215

Closed
ethowitz opened this issue Feb 4, 2022 · 0 comments · Fixed by #1216
Closed

Add BrowserID support to Tokenserver #1215

ethowitz opened this issue Feb 4, 2022 · 0 comments · Fixed by #1216
Labels
tokenserver

Comments

@ethowitz
Copy link
Contributor

ethowitz commented Feb 4, 2022

We've determined that there are enough Sync users still using BrowserID that we should continue support for it. The legacy Tokenserver verifies BrowserID assertions by making a request to FxA – the new Tokenserver should do the same.

Acceptance Criteria

  • Add a BrowserIdVerifier that implements VerifyToken and makes a request to FxA to verify BrowserID assertions. Reference this class from the legacy Tokenserver: https://github.com/mozilla-services/tokenserver/blob/master/tokenserver/verifiers.py#L112
  • In the extractors, check whether the Authorization header includes "Bearer" or "BrowserID" and parse the token accordingly
  • Add unit tests and integration tests to ensure that the functionality exactly duplicates that of the legacy Tokenserver
ethowitz pushed a commit that referenced this issue Feb 4, 2022
feat: add BrowserID support to Tokenserver
79e9735 
Closes #1215
@ethowitz ethowitz mentioned this issue Feb 4, 2022
Merged
ethowitz pushed a commit that referenced this issue Feb 7, 2022
feat: add BrowserID support to Tokenserver
20c446b 
Closes #1215
ethowitz pushed a commit that referenced this issue Feb 7, 2022
feat: add BrowserID support to Tokenserver
9660d46 
Closes #1215
ethowitz pushed a commit that referenced this issue Feb 9, 2022
feat: add BrowserID support to Tokenserver
af5a70f 
Closes #1215
ethowitz pushed a commit that referenced this issue Feb 28, 2022
feat: add BrowserID support to Tokenserver
9d90db3 
Closes #1215
ethowitz pushed a commit that referenced this issue Mar 22, 2022
feat: add BrowserID support to Tokenserver
c0d0341 
Closes #1215
ethowitz added a commit that referenced this issue Mar 31, 2022
@ethowitz
feat: add BrowserID support for Tokenserver (#1216)
38d6a27 
Closes #1215
pjenvey added a commit that referenced this issue Apr 26, 2022
@pjenvey
chore: disable grpcio openssl
48044ba 
(#1215 follow up) we shouldn't need it enabled since moving to reqwest+rustls

and upgrade the easier dependencies

Issue #1215
@pjenvey pjenvey mentioned this issue Apr 26, 2022
Merged
pjenvey added a commit that referenced this issue Apr 26, 2022
@pjenvey
chore: disable grpcio openssl
bfe1829 
(#1215 follow up) we shouldn't need it enabled since moving to reqwest+rustls

and upgrade the easier dependencies

Issue #1215
pjenvey added a commit that referenced this issue Apr 27, 2022
@pjenvey
chore: disable grpcio openssl
08b6ccb 
(#1215 follow up) we shouldn't need it enabled since moving to reqwest+rustls

and upgrade the easier dependencies

Issue #1215
pjenvey added a commit that referenced this issue Apr 27, 2022
@pjenvey
chore: disable grpcio openssl (#1288)
8ff7a40 
(#1215 follow up) we shouldn't need it enabled since moving to reqwest+rustls

and upgrade the easier dependencies

Issue #1215
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tokenserver
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add BrowserID support for Tokenserver mozilla-services/syncstorage-rs
1 participant
@ethowitz