Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tokenserver metrics #1214

Closed
ethowitz opened this issue Feb 4, 2022 · 0 comments · Fixed by #1218
Closed

Fix Tokenserver metrics #1214

ethowitz opened this issue Feb 4, 2022 · 0 comments · Fixed by #1218

Comments

@ethowitz
Copy link
Contributor

ethowitz commented Feb 4, 2022

When tokenserver.disable_syncstorage is set to true, there is no primary application state; the only application state that exists is Tokenserver's, which doesn't store the Metrics object. In the Tokenserver extractors, we're using the Metrics: FromRequest impl to get access to the metrics, which looks at the syncstorage application state. To resolve this, we'll either want to manually reach into the Tokenserver application state or create a wrapper type around the metrics so we can impl FromRequest specifically for Tokenserver's metrics object.

ethowitz pushed a commit that referenced this issue Feb 9, 2022
ethowitz pushed a commit that referenced this issue Feb 28, 2022
ethowitz added a commit that referenced this issue Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant