Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove middleware::sentry::queue_report #1021

Closed
pjenvey opened this issue Mar 10, 2021 · 0 comments · Fixed by #1040
Closed

Remove middleware::sentry::queue_report #1021

pjenvey opened this issue Mar 10, 2021 · 0 comments · Fixed by #1040
Assignees
@ethowitz
Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. cleanup good first bug Low priority, but valuable contributions

Comments

@pjenvey
Copy link
Member

pjenvey commented Mar 10, 2021

With the removal of DbMiddleware there's no longer any use of the queue_report function, so it should be removed (#693 (comment)).
@pjenvey pjenvey added cleanup 1 Estimate - xs - This is a trivial change with clearly defined parameters. good first bug Low priority, but valuable contributions labels Mar 10, 2021
ethowitz pushed a commit that referenced this issue Apr 9, 2021
refactor: Remove middleware::sentry::queue_report
1496ac7 
Closes: #1021
@ethowitz ethowitz mentioned this issue Apr 9, 2021
Merged
@ethowitz ethowitz self-assigned this Apr 9, 2021
ethowitz added a commit that referenced this issue Apr 9, 2021
@ethowitz
refactor: Remove middleware::sentry::queue_report (#1040)
0dccb00 
Closes: #1021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ethowitz ethowitz

Labels
1 Estimate - xs - This is a trivial change with clearly defined parameters. cleanup good first bug Low priority, but valuable contributions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: Remove middleware::sentry::queue_report mozilla-services/syncstorage-rs
2 participants
@pjenvey @ethowitz