Skip to content

Commit

Permalink
doc: Add reminders to notify iOS team on changing limits (#1028)
Browse files Browse the repository at this point in the history
Closes #1026
  • Loading branch information
jrconlin authored Mar 19, 2021
1 parent ed14344 commit 9656790
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
6 changes: 6 additions & 0 deletions spanner_config.ini
Original file line number Diff line number Diff line change
@@ -1,2 +1,8 @@
# Limit the number of incoming records (See issue #298/#333/#869)
# NOTE: Make sure to alert the iOS team after altering any of these values
# in production <https://github.com/mozilla-mobile/firefox-ios/issues>
# * limits.MAX_REQUEST_BYTES
# * limits.MAX_POST_REQCORDS
# * limits.MAX_TOTAL_RECORDS
# * limits.MAX_TOTAL_BYTES
limits.max_total_records=1664
9 changes: 9 additions & 0 deletions src/db/spanner/BATCH_COMMIT.txt
Original file line number Diff line number Diff line change
Expand Up @@ -56,3 +56,12 @@ Totals:

- quota: True
6 + 19968 + 1 + 6 = 19981


**NOTE** iOS hardcodes syncstorage values. ANY ALTERATION OF THE FOLLOWING VALUES
MUST REQUIRE FILING AN ISSUE WITH THE iOS TEAM!
<https://github.com/mozilla-mobile/firefox-ios/issues>
* MAX_REQUEST_BYTES
* MAX_POST_REQCORDS
* MAX_TOTAL_RECORDS
* MAX_TOTAL_BYTES

0 comments on commit 9656790

Please sign in to comment.