bug-1935274: increase message length for BugzillaRestHTTPUnexpectedError #6833
Conversation
relud
force-pushed
the
relud-bug-1935274-bugzilla-unexpected
branch
from
af16857 to
a8337e7
Compare
| # it, so let's dump to a string and truncate that to 100 characters. | ||
| payload_data = response.content[:100] | ||
| # it, so let's dump to a string and truncate that to 200 characters. | ||
| payload_data = response.content[:200] |
There was a problem hiding this comment.
in sentry we can see that response.content is a bytes and not a string. I tried adding a .decode("utf8") here, but found out that in tests we mock it as a string. I decided the test is close enough and to leave it as is, rather than try to modify the test.
There was a problem hiding this comment.
That's my bad. I should remember that .content returns a bytes. It gets !r later, so it doesn't need to be a string. We could fix the mocked test to make it a bytes.
There was a problem hiding this comment.
There's also response.text, which is the same as .content, but decoded to a Unicode string.
There was a problem hiding this comment.
I wouldn't switch to .text here. I think we want to know what the payload is and avoid additional transforms that can kick up other issues.
100 characters wasn't enough information to understand the error, so doubling it.