Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update obs-common to pick up the ack_deadline_timeout fix #6832

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Dec 6, 2024

This fixes subscription creation in the local dev environment so the ack deadline is 600 seconds which gives the processor enough time to retrieve a crash id, process the crash, and ack the crash id. Prior to this fix, subscriptions would use the default 10 seconds and that's not enough time to process crash reports.

We fixed this originally in bug-1912979, but that fix was dropped when we moved utilities to obs-common.

This fixes subscription creation in the local dev environment so the ack
deadline is 600 seconds which gives the processor enough time to
retrieve a crash id, process the crash, and ack the crash id. Prior to
this fix, subscriptions would use the default 10 seconds and that's not
enough time to process crash reports.

We fixed this originally in bug-1912979, but that fix was dropped when
we moved utilities to obs-common.
@willkg willkg requested a review from a team as a code owner December 6, 2024 13:39
@willkg willkg added this pull request to the merge queue Dec 6, 2024
@willkg
Copy link
Contributor Author

willkg commented Dec 6, 2024

Thank you!

Merged via the queue into main with commit 244d16b Dec 6, 2024
1 check passed
@willkg willkg deleted the fix-ack-deadline branch December 6, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants