bug-1933774: omit collector-added fields from Crash Annotations tab #6823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the collector-added fields from the Crash Annotations tab of the report view. It's confusing that these were there. This also adds "version" to the Debug tab. This value is the version of the raw crash structure in storage. It's relevant to Socorro internals, but nothing else.
This said to remove it after 2022. It's after 2022 now.
relud
approved these changes
Dec 3, 2024
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the collector-added fields from the Crash Annotations tab. For anyone who isn't a crash ingestion system maintainer, these fields are confusing because they're not part of the crash report payload.
After these changes, the fields will be omitted from the public and protected annotations lists in the Crash Annotations tab.
This also adds "version" to the Debug tab. This value represents the schema version of the raw crash structure. It's relevant to crash ingestion internals and nothing else, so having it in the Debug tab is helpful (though at this point, everything is version 2 so it's not wildly interesting anymore).
This also removes a few lines from the report view template that said we could remove them in 2022. That day has long passed.
To test: