Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a "thismonth" option to the date argument for fetch_crashids #6822

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

willkg
Copy link
Contributor

@willkg willkg commented Nov 27, 2024

This adds a "thismonth" value to the value domain for the `--date" argument because it's not uncommon to be testing signature generation changes for situations that have happened in the last month, but not in the last week.

$ just shell

app@socorro:/app$ socorro-cmd fetch_crashids --date=thisweek --signature-contains=g_malloc

app@socorro:/app$ socorro-cmd fetch_crashids --date=thismonth --signature-contains=g_malloc
9c924bb4-cc8d-4071-afef-000140241031
72d845fc-6f33-4f44-9203-1dc490241104
e4a0a8dd-341b-430a-9f6a-2ad0c0241028
aef97233-ca73-4ba9-a6d1-c8a280241104
ede7036b-4927-41a0-834e-9e4a80241105
4ea1423a-fce6-45a9-95e2-6a05e0241110
f17cd077-17a7-46cd-a378-2dc8a0241102
8d1cc235-dcbd-4606-a99d-eaf840241104
2b89f970-0451-43fc-a237-ecf7a0241106

This adds a "thismonth" value to the value domain for the `--date"
argument because it's not uncommon to be testing signature generation
changes for situations that have happened in the last month, but not in
the last week.
@willkg willkg requested a review from a team as a code owner November 27, 2024 17:00
@willkg willkg added this pull request to the merge queue Nov 29, 2024
@willkg
Copy link
Contributor Author

willkg commented Nov 29, 2024

Thank you!

Merged via the queue into main with commit e979da2 Nov 29, 2024
1 check passed
@willkg willkg deleted the fetch_crashids-thismonth branch November 29, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants