Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bin/process_crashes.sh and dev docs for obs-common #6813

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

relud
Copy link
Member

@relud relud commented Nov 20, 2024

No description provided.

@relud relud requested a review from a team as a code owner November 20, 2024 16:55
# Add all the crash ids to the pubsub topic
app@socorro:/app$ cat crashids.txt | socorro-cmd pubsub publish test local-standard-topic
app@socorro:/app$ cat crashids.txt | pubsub-cli publish test local-standard-topic
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in testing I found out this line doesn't work without mozilla-services/obs-common#54

Copy link
Contributor

@willkg willkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Seems like the fix for pubsub-cli is in here, too.

app@socorro:/app$ cat crashids.txt | pubsub-cli publish test local-standard-topic
Publishing crash ids to topic: 'local-standard-topic':
18
17
15
16
12
11
13
14
20
19
app@socorro:/app$ pubsub-cli pull test local-standard-sub --max-messages=10
Pulling crash id from subscription 'local-standard-sub':
crash id: b'58fb38bf-51c2-4ea5-b3c0-ca03c0241121'
crash id: b'ff8792cc-b3ca-4905-927e-aecc60241121'
crash id: b'5826dbab-37be-4604-a69d-fa5500241121'
crash id: b'4fe6bacd-82c8-48a9-9fed-3f6070241121'
crash id: b'61be4bb0-2c7c-4961-b058-93dc70241121'
crash id: b'442e3454-2eba-4981-984b-9eb2b0241121'
crash id: b'db81888a-af13-4eef-9a2f-377620241121'
crash id: b'fc8df39b-ad75-4490-ae8d-22a1e0241121'
crash id: b'7cef2bcb-ef21-4ea2-b01d-f026a0241121'
crash id: b'c8cd4852-733b-4348-a2f4-d7b740241121'

@relud relud added this pull request to the merge queue Nov 22, 2024
Merged via the queue into main with commit b2edddc Nov 22, 2024
1 check passed
@relud relud deleted the relud-fix-obs-common branch November 22, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants