Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around dependabot not updating docker-compose #6810

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

relud
Copy link
Member

@relud relud commented Nov 19, 2024

this leaves out hopsoft/graphite-statsd and mozilla/socorro_collector:latest because they are using "latest" which will get updates without dependabot, and leaves out mozilla/socorro_elasticsearch:1.4.5 because it's going away

@relud relud requested a review from a team as a code owner November 19, 2024 20:51
Copy link
Contributor

@smarnach smarnach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

this leaves out hopsoft/graphite-statsd and mozilla/socorro_collector:latest because they are using "latest" which will get updates without dependabot.

I've got two questions about this. First, I don't think we are still updating mozilla/socorro_collector, since it's on Docker Hub, and we now only push to GAR. Is this intended? And second, should we be using latest? At least for statsd, I think it would be better to pin it to a specific version, in particular now that we have a way to make dependabot take care of upgrades.

@relud
Copy link
Member Author

relud commented Nov 20, 2024

i should make the antenna image public and use the gar version. should still be latest tho, imo.

for statsd, iirc the image hasn't been touched in like 7 years, and there is no equivalent non-latest image tag, so latest is what we get until we have time to set up a replacement.

@relud relud added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit 52f5d8b Nov 20, 2024
1 check passed
@relud relud deleted the relud-dependabot-docker-compose branch November 20, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants