Bug 1929829 - Ignore g_malloc when generating signatures #6798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willkg
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
app@socorro:/app$ ./mybin/test_signature_change.sh g_malloc
Working on 'g_malloc' ...
Crash id: 9c924bb4-cc8d-4071-afef-000140241031
Original: g_malloc
New: g_slice_alloc
Same?: False
Crash id: 72d845fc-6f33-4f44-9203-1dc490241104
Original: g_malloc
New: g_strndup
Same?: False
Doesn't seem like it helps a whole lot, but you can do a follow-up PR with additional changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.