Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug 1399513 - Add rust oom signature #3977

Merged
merged 2 commits into from
Sep 13, 2017
Merged

Conversation

jdm
Copy link
Contributor

@jdm jdm commented Sep 12, 2017

It would be nice to add core::result::unwrap_failed<hashglobe::FailedAllocationError>, but it apparently is transformed in the signature into a generic unwrap_failed<T> per https://crash-stats.mozilla.com/report/index/d54a2975-9c55-4567-a92f-c755c0170903 :/

@willkg
Copy link
Contributor

willkg commented Sep 12, 2017

Is there a Bugzilla bug related to this change? If not, can we write one up so we can associate this?

@willkg
Copy link
Contributor

willkg commented Sep 12, 2017

Oops--I see the bug now. Sorry about that!

@willkg
Copy link
Contributor

willkg commented Sep 12, 2017

Oh, my bad. That bug isn't a Socorro but. Can you open up a Socorro bug for this change? Then we can associate this PR with that bug and move forward.

@willkg
Copy link
Contributor

willkg commented Sep 13, 2017

@jdm Can you write up a Socorro bug for this change?

@willkg
Copy link
Contributor

willkg commented Sep 13, 2017

@jdm With this change, the signature for the example crash didn't change at all:

app@3fd1310168d2:/app$ python -m socorro.signature d54a2975-9c55-4567-a92f-c755c0170903
Original: core::result::unwrap_failed<T> | hashglobe::hash_map::HashMap<T>::entry<T>
New:      core::result::unwrap_failed<T> | hashglobe::hash_map::HashMap<T>::entry<T>
Same?:    True

Is the signature for the crash in the PR description supposed to change? If not, are there other example crashes we can test?

@jdm
Copy link
Contributor Author

jdm commented Sep 13, 2017

This is supposed to mark the crash report as an OOM, not modify the signature. This change is based on https://crash-stats.mozilla.com/report/index/cb3e453d-5135-4b57-8d9a-656330170820.

@jdm
Copy link
Contributor Author

jdm commented Sep 13, 2017

@jdm
Copy link
Contributor Author

jdm commented Sep 13, 2017

Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1399515 for the unrelated comment I originally made.

@willkg
Copy link
Contributor

willkg commented Sep 13, 2017

Using the cb3e453d-5135-4b57-8d9a-656330170820 crash:

app@2e8a1040c15d:/app$ python -m socorro.signature cb3e453d-5135-4b57-8d9a-656330170820
Original: alloc::oom::oom | std::collections::hash::map::HashMap<T>::resize<T> | std::collections::hash::map::HashMap<T>::entry<T> | style::selector_map::SelectorMap<T>::insert<T>
New:      OOM | unknown | alloc::oom::oom | std::collections::hash::map::HashMap<T>::resize<T> | std::collections::hash::map::HashMap<T>::entry<T> | style::selector_map::SelectorMap<T>::insert<T>
Same?:    False

Is that the kind of change you're expecting with this PR?

@willkg willkg self-requested a review September 13, 2017 15:22
@jdm
Copy link
Contributor Author

jdm commented Sep 13, 2017

Yes.

@willkg willkg merged commit d4b8836 into mozilla-services:master Sep 13, 2017
@willkg
Copy link
Contributor

willkg commented Sep 13, 2017

Thank you!

@willkg willkg changed the title Add rust oom signature bug 1399513 - Add rust oom signature Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants