-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug 1399513 - Add rust oom signature #3977
Conversation
Is there a Bugzilla bug related to this change? If not, can we write one up so we can associate this? |
Oops--I see the bug now. Sorry about that! |
Oh, my bad. That bug isn't a Socorro but. Can you open up a Socorro bug for this change? Then we can associate this PR with that bug and move forward. |
@jdm Can you write up a Socorro bug for this change? |
@jdm With this change, the signature for the example crash didn't change at all:
Is the signature for the crash in the PR description supposed to change? If not, are there other example crashes we can test? |
This is supposed to mark the crash report as an OOM, not modify the signature. This change is based on https://crash-stats.mozilla.com/report/index/cb3e453d-5135-4b57-8d9a-656330170820. |
Filed https://bugzilla.mozilla.org/show_bug.cgi?id=1399515 for the unrelated comment I originally made. |
Using the cb3e453d-5135-4b57-8d9a-656330170820 crash:
Is that the kind of change you're expecting with this PR? |
Yes. |
Thank you! |
It would be nice to add
core::result::unwrap_failed<hashglobe::FailedAllocationError>
, but it apparently is transformed in the signature into a genericunwrap_failed<T>
per https://crash-stats.mozilla.com/report/index/d54a2975-9c55-4567-a92f-c755c0170903 :/