Skip to content
This repository has been archived by the owner on Jan 17, 2023. It is now read-only.

Change frame.js to use reactruntime #1713

Closed
ianb opened this issue Oct 7, 2016 · 0 comments · Fixed by #1841
Closed

Change frame.js to use reactruntime #1713

ianb opened this issue Oct 7, 2016 · 0 comments · Fixed by #1841
Assignees
@ianb
Milestone
Betelgeuse

Comments

@ianb
Copy link
Contributor

ianb commented Oct 7, 2016

This would mean changing frame.js to use the Head/Body stuff, making a page and moving the resources into that page. Some items might get moved out of server.js and into a page-specific server.js (though it's unclear what parts); the server would have to be mounted on "/".
@ianb ianb added this to the Next Tasks milestone Oct 12, 2016
@ianb ianb modified the milestones: Next Tasks, Betelgeuse Oct 20, 2016
@ianb ianb self-assigned this Oct 24, 2016
@ianb ianb mentioned this issue Oct 25, 2016
Closed
ianb added a commit that referenced this issue Oct 25, 2016
@ianb
Initial rearrangement to convert frame.js to reactruntime page (not y…
1ed7091 
…et functional). Related to #1713
ianb added a commit that referenced this issue Oct 25, 2016
@ianb
Get everything working from previous commit
27f55ff 
Move the model code out of frame.js/view.js and into model.js
rename clientglue to controller
Fix imports given new relative location of files
Remove references to the Profile
Comment out code related to Save Full Page
Move the handler for GET /:id/:domain out of root server.js and into page-specific server.js
Part of the work for #1713
@ianb ianb mentioned this issue Oct 25, 2016
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ianb ianb

Labels
None yet
Projects
None yet
Milestone
Betelgeuse
Development

Successfully merging a pull request may close this issue.

r?fzzzy Refactor frame mozilla-services/screenshots
1 participant
@ianb