Skip to content
This repository has been archived by the owner on Jan 12, 2019. It is now read-only.

feat: refactor handler into singleton class #6

Merged
merged 1 commit into from
Mar 22, 2016
Merged

feat: refactor handler into singleton class #6

merged 1 commit into from
Mar 22, 2016

Conversation

bbangert
Copy link
Member

@codecov-io
Copy link

Current coverage is 100.00%

Merging #6 into master will not affect coverage as of ba2666c

@@            master      #6   diff @@
======================================
  Files           11      11       
  Stmts          322     322       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            322     322       
  Partial          0       0       
  Missed           0       0

Review entire Coverage Diff as of ba2666c

Powered by Codecov. Updated on successful CI builds.

jrconlin
jrconlin reviewed Mar 22, 2016
View reviewed changes
push_processor/handler.py
@@ -18,68 +18,66 @@
here_dir = os.path.abspath(os.path.dirname(__file__))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you only use this once, in an init for the class. You could just move it there and get rid of the last global.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed!

@bbangert bbangert force-pushed the feat/refactor-lambda-class branch from 46eaa9a to ba2666c Compare March 22, 2016 04:31
@jrconlin
Copy link
Member

r+

jrconlin added a commit that referenced this pull request Mar 22, 2016
@jrconlin
Merge pull request #6 from mozilla-services/feat/refactor-lambda-class
b4fcf4e 
feat: refactor handler into singleton class
@jrconlin jrconlin merged commit b4fcf4e into master Mar 22, 2016
@bbangert bbangert deleted the feat/refactor-lambda-class branch March 22, 2016 15:32
@bbangert bbangert mentioned this pull request Apr 11, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@jrconlin jrconlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbangert @codecov-io @jrconlin