Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Add libcurl4 to Dockerfile #95

Merged
merged 2 commits into from
Jan 21, 2021
Merged

bug: Add libcurl4 to Dockerfile #95

merged 2 commits into from
Jan 21, 2021

Conversation

jrconlin
Copy link
Member

Closes #94

Description

App was failing to launch because libcurl4 was not being loaded into the app_1 dockerfile.

Testing

ROCKET_BROADCASTER_AUTH={"test"=["foobar"]} ROCKET_READER_AUTH={"autopush"=["quux"]} docker-compose up

should report app_1 starting. You can spot this in the log file, via something similar to:

app_1  | {"Logger":"megaphone-0.1.6","Type":"megaphone:log","Hostname":"...","Pid":1,"Severity":6,"Timestamp":...,"Fields":{"msg":"Starting up"}}

Issue(s)

Closes #94.

@jrconlin jrconlin requested a review from a team January 11, 2021 21:52
@@ -1 +1 @@
nightly-2020-01-09
nightly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit concerned this could randomly break the build in the future. It's been a while since it's happened, but I recall Rocket occasionally having issues with the latest nightly

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose, I mostly updated to normal nightly because it's far easier to forget to update this with the "latest" version. If we hit a problem again, we can freeze until we know it works again.

@pjenvey pjenvey merged commit 35614eb into master Jan 21, 2021
@pjenvey pjenvey deleted the bug/94-docker branch January 21, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

latest tag on hub.docker.com broken?
2 participants