Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

refactor: split clients and agent off settings #945

Merged
merged 1 commit into from
Jun 29, 2017
Merged

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Jun 29, 2017

issue #632

autopush/http.py Outdated
ap_settings,
db=db,
routers=routers,
db,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the keyword declaration for clarity?

bbangert
bbangert previously approved these changes Jun 29, 2017
@codecov-io
Copy link

codecov-io commented Jun 29, 2017

Codecov Report

Merging #945 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #945   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          57     57           
  Lines        9569   9588   +19     
=====================================
+ Hits         9569   9588   +19
Impacted Files Coverage Δ
autopush/tests/test_router.py 100% <100%> (ø) ⬆️
autopush/tests/test_websocket.py 100% <100%> (ø) ⬆️
autopush/tests/test_integration.py 100% <100%> (ø) ⬆️
autopush/web/health.py 100% <100%> (ø) ⬆️
autopush/http.py 100% <100%> (ø) ⬆️
autopush/settings.py 100% <100%> (ø) ⬆️
autopush/main.py 100% <100%> (ø) ⬆️
autopush/router/simple.py 100% <100%> (ø) ⬆️
autopush/websocket.py 100% <100%> (ø) ⬆️
autopush/router/__init__.py 100% <100%> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef0b74d...70129bc. Read the comment docs.

@jrconlin jrconlin merged commit 2594f9e into master Jun 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants