This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Serialize Decimal correctly for ios aps #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #900 +/- ##
=======================================
Coverage 100% 100%
=======================================
Files 56 56
Lines 9709 10088 +379
=======================================
+ Hits 9709 10088 +379
Continue to review full report at Codecov.
|
bbangert
reviewed
May 20, 2017
autopush/router/apns2.py
Outdated
| class ComplexEncoder(json.JSONEncoder): | ||
| def default(self, obj): | ||
| if isinstance(obj, Decimal): | ||
| return int(float(obj.to_integral())) |
There was a problem hiding this comment.
Why not use to_integral_value? The docs indicate it should already return an int.
There was a problem hiding this comment.
And, this is why reading a code review comment while following a keynote is probably not a good idea. Misread your comment. sigh
pjenvey
reviewed
May 20, 2017
autopush/router/apns2.py
Outdated
| class ComplexEncoder(json.JSONEncoder): | ||
| def default(self, obj): | ||
| if isinstance(obj, Decimal): | ||
| return int(float(obj.to_integral_value())) |
There was a problem hiding this comment.
should kill the float() here: to_integral_value already clips it
bbangert
approved these changes
May 20, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #899