This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: temporarily allow aps data via registration message #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #896 +/- ##
========================================
Coverage 100% 100%
========================================
Files 54 55 +1
Lines 9780 11172 +1392
========================================
+ Hits 9780 11172 +1392
Continue to review full report at Codecov.
|
bbangert
reviewed
May 15, 2017
| @@ -133,7 +133,7 @@ def _route(self, notification, router_data): | |||
| payload["cryptokey"] = notification.headers["crypto_key"] | |||
| elif "encryption_key" in notification.headers: | |||
| payload["enckey"] = notification.headers["encryption_key"] | |||
| payload['aps'] = {"content-available": 1} | |||
| payload['aps'] = router_data.get('aps', {"content-available": 1}) | |||
There was a problem hiding this comment.
If there's an aps entry, then content-available doesn't need to be present?
There was a problem hiding this comment.
Yes.
There needs to be an "aps" block, thus why I default to "{content-available": 1}, however, 'content-available is equivalent to our silent notifications, so it can be problematic. I presume that the folks providing the override aps data are knowledgeable and allow for full customization.
pjenvey
approved these changes
May 15, 2017
bbangert
approved these changes
May 15, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #887