Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

add a /_memusage API on a separate (internal port) #812

Merged
merged 2 commits into from
Feb 10, 2017
Merged

add a /_memusage API on a separate (internal port) #812

merged 2 commits into from
Feb 10, 2017

Conversation

pjenvey
Copy link
Member

@pjenvey pjenvey commented Feb 10, 2017

for debugging our memory usage

issue #802

(includes gcdump.py from pypy with slight changes to process the result of pypy's gc.dump_rpy_heap)

@pjenvey pjenvey added this to the PUSHSVC-0: quality milestone Feb 10, 2017
@pjenvey pjenvey requested review from jrconlin and bbangert February 10, 2017 00:23
bbangert
bbangert approved these changes Feb 10, 2017
View reviewed changes
Copy link
Member

@bbangert bbangert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup.

jrconlin
jrconlin approved these changes Feb 10, 2017
View reviewed changes
Copy link
Member

@jrconlin jrconlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd guess that using buffer io would corrupt the data, so fine with going to file. Might want to check for write access to the dir first, but not imperative.

@jrconlin jrconlin merged commit fe90445 into master Feb 10, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bbangert bbangert bbangert approved these changes

@jrconlin jrconlin jrconlin approved these changes

Assignees
No one assigned
Labels
enhancement p1
Projects
None yet
Milestone
PUSHSVC-0: quality
Development

Successfully merging this pull request may close these issues.
3 participants
@pjenvey @jrconlin @bbangert