This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: Add exception info to log.info call #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
suggested changes
Nov 22, 2016
| @@ -179,7 +179,9 @@ def _validation_err(self, fail): | |||
| exc = fail.value | |||
| self.log.info(format="Request validation error", | |||
| status_code=exc.status_code, | |||
| errno=exc.errno) | |||
| errno=exc.errno, | |||
| message=exc.message or "No message", | |||
There was a problem hiding this comment.
we probably want format="Request validation error: %s" % exc). we don't use a message kwarg for any other log calls
Current coverage is 100% (diff: 100%)@@ master #743 diff @@
====================================
Files 46 46
Lines 9171 9171
Methods 0 0
Messages 0 0
Branches 0 0
====================================
Hits 9171 9171
Misses 0 0
Partials 0 0
|
pjenvey
approved these changes
Nov 22, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #742