This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: retain date when checking message tables #727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 100% (diff: 100%)
|
pjenvey
suggested changes
Nov 8, 2016
| @@ -129,10 +129,10 @@ def make_rotating_tablename(prefix, delta=0, date=None): | |||
|
|
|||
|
|
|||
| def create_rotating_message_table(prefix="message", read_throughput=5, | |||
| write_throughput=5, delta=0): | |||
| write_throughput=5, delta=0, date=None): | |||
| # type: (str, int, int, int) -> Table | |||
There was a problem hiding this comment.
Maybe you can make create_rotating_message_table's arguments more consistent with get_rotating_message_table's while you're here?
There was a problem hiding this comment.
Sure, updated to defer the call to a thread.
bbangert
force-pushed
the
feat/issue-722
branch
from
4c1a377 to
800ded5
Compare
Ensures the date argument is passed along with the table name when creating the rotating message table during the get_rotating_message_table call. Closes #722
bbangert
force-pushed
the
feat/issue-722
branch
from
800ded5 to
c7aae0c
Compare
pjenvey
approved these changes
Nov 8, 2016
jrconlin
approved these changes
Nov 8, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures the date argument is passed along with the table name
when creating the rotating message table during the
get_rotating_message_table call.
Closes #722