This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Do not remove router_type from UAID info #576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Webpush web handler should not remove router_type from UAID information. Also fixed error message formatting and added appropriate test to ensure that router_type persists. closes #549
Current coverage is 100% (diff: 100%)@@ master #576 diff @@
====================================
Files 42 42
Lines 8774 8775 +1
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 8774 8775 +1
Misses 0 0
Partials 0 0
|
|
r+ |
|
I don't get it, why doesn't this match how _router_completed in endpoint.py works? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpush web handler should not remove router_type from UAID information.
Also fixed error message formatting and added appropriate test to ensure
that router_type persists.
closes #549
@bbangert, @pjenvey r?