This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
bug: Do not record the GCM data overflow error #567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return the GCM data overflow error to the subscription server, but there's no need to record it into Sentry. Closes #552
|
r+ |
Current coverage is 100% (diff: 100%)@@ master #567 diff @@
====================================
Files 42 42
Lines 8753 8803 +50
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 8753 8803 +50
Misses 0 0
Partials 0 0
|
|
might this be applicable to FCM too? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return the GCM data overflow error to the subscription server, but
there's no need to record it into Sentry.
Closes #552
@bbangert , @pjenvey r?