This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
Feature/issue 509 #513
Merged
Feature/issue 509 #513
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WebPushHandler was not configured to run with autoendpoint. This commit fixes the URL registration.
Add test_web_webpush tests which were accidentally missed in an earlier commit. Update self.assert tests to use nose test utils which actually trigger errors.
This add's a endpoint_diagnostic CLI that will resolve an endpoint to its UAID/CHID and router record info along with applicable valid channels. Closes #509
Current coverage is 100%@@ master #513 diff @@
======================================
Files 37 40 +3
Lines 8200 8341 +141
Methods 0 0
Messages 0 0
Branches 0 0
======================================
+ Hits 8191 8341 +150
+ Misses 9 0 -9
Partials 0 0
|
|
Nice! I wonder if it makes sense to add a little |
|
I should note that there's still plenty of self.assert's in the code, these are just the ones that were failing that PyCharm picked up as it runs tox slightly differently. We should still replace the remainder so that detecting these aren't an accident. |
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a few bugs in existing tests that were using self.assert which failed to verify the value.
Fixes issue with the wpush endpoint not being registered in main.py for autoendpoint.
Add's the test_web_webpush which should've been included with the prior webpush endpoint refactor.
The last commit add's a endpoint_diagnostic CLI that will resolve an endpoint to its
UAID/CHID and router record info along with applicable valid channels.
Closes #509
@jrconlin r?