This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: update logging for newstyle twisted and file output #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbangert
force-pushed
the
feat/issue-419
branch
6 times, most recently
from
6099a91 to
d820bcd
Compare
Updates all logging calls to use the newer logging utilities in twisted. This obsoletes the use of eliot, as twisteds logger can handle arbitrary keywords. The logging handling has been revamped into a more easily testable class that implements twisteds IObserver for easy logger observing. log_level support has been re-added so that calls can be appropriately scoped by logging type. Existing info/msg log calls now use appropriate log levels, with delayed function calls to prevent unnecessary overhead when formatting objects if the log message is ignored. Closes #419
bbangert
force-pushed
the
feat/issue-419
branch
from
d820bcd to
547eb1e
Compare
|
r+ |
jrconlin
added a commit
that referenced
this pull request
Mar 21, 2016
feat: update logging for newstyle twisted and file output
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates all logging calls to use the newer logging utilities in
twisted. This obsoletes the use of eliot, as twisteds logger can
handle arbitrary keywords. The logging handling has been revamped
into a more easily testable class that implements twisteds IObserver
for easy logger observing.
log_level support has been re-added so that calls can be appropriately
scoped by logging type. Existing info/msg log calls now use appropriate
log levels, with delayed function calls to prevent unnecessary overhead
when formatting objects if the log message is ignored.
Closes #419
@jrconlin r?