This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
chore: bump to the latest twisted per CVE-2019-12387 #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and adapt tests to it Closes #1336
pjenvey
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1337 +/- ##
==========================================
+ Coverage 99.79% 99.79% +<.01%
==========================================
Files 64 64
Lines 10415 10422 +7
==========================================
+ Hits 10394 10401 +7
Misses 21 21
Continue to review full report at Codecov.
|
jrconlin
approved these changes
Jun 25, 2019
| @@ -96,8 +96,8 @@ def test_fail_401(self): | |||
| def test_fail_500(self): | |||
| self._m_response.code = 500 | |||
| content = "OMG" | |||
| self._m_response.headers.addRawHeader('Retry-After', 123) | |||
| self._m_response.headers.addRawHeader('Retry-After', "123") | |||
There was a problem hiding this comment.
Well, I guess "Yay for consistency!" and all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and adapt tests to it
Closes #1336