This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: add dockerflow callbacks for endpoint #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjenvey
suggested changes
Sep 28, 2018
autopush/web/dockerflow.py
Outdated
|
|
||
| @cyclone.web.asynchronous | ||
| def get(self): | ||
| self.set_status(200) |
There was a problem hiding this comment.
nit: default's 200 so this line can be killed
| from autopush.web.base import BaseWebHandler | ||
|
|
||
|
|
||
| class VersionHandler(BaseWebHandler): |
There was a problem hiding this comment.
let's have VersionHandler call self.set_header("Content-Type", "application/json")
Also let's have both new handlers override authenticate_peer_cert to do nothing (skipping auth checks) like the handlers in web.health/memusage
Codecov Report
@@ Coverage Diff @@
## master #1294 +/- ##
==========================================
- Coverage 99.93% 99.76% -0.18%
==========================================
Files 60 61 +1
Lines 9831 9897 +66
==========================================
+ Hits 9825 9874 +49
- Misses 6 23 +17
Continue to review full report at Codecov.
|
pjenvey
approved these changes
Oct 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1293