bug: doc fixup #1261
bug: doc fixup #1261
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1261 +/- ##
======================================
Coverage 100% 100%
======================================
Files 59 59
Lines 9523 9525 +2
======================================
+ Hits 9523 9525 +2
Continue to review full report at Codecov.
|
autopush/db.py
Outdated
| @@ -468,6 +468,10 @@ def __init__(self, **kwargs): | |||
| conf = kwargs | |||
| if not conf.get("endpoint_url"): | |||
| conf["endpoint_url"] = os.getenv("AWS_LOCAL_DYNAMODB") | |||
| creds = os.getenv("AWS_LOCAL_CREDS") | |||
There was a problem hiding this comment.
autopush-rs hardcodes creds to bogus whenever AWS_LOCAL_DYNAMODB is set. I'm thinking we do the same here (killing AWS_LOCAL_CREDS), as I don't think anyone will ever need custom creds when pointing to a local ddb
There was a problem hiding this comment.
I was debating that myself. The only potential reason I could come up with to keep them separate was the low percentile chance that they actually had some specific credentials that they wanted to use.
Yeah, I have really dumb arguments with myself.
docker-compose.yml
Outdated
| hostname: autopush | ||
| environment: | ||
| - LOCAL_HOSTNAME=localhost | ||
| - ROUTER_HOSTNAME=autopush | ||
| - AWS_LOCAL_DYNAMODB=http://dynamodb:8000 | ||
| - AWS_LOCAL_CREDS=Bogus:Bogus |
There was a problem hiding this comment.
one more thing, forgot to kill it here and below (possibly in the commit message too?)
jrconlin
force-pushed
the
docs
branch
2 times, most recently
from
a3becaa to
fdb3811
Compare
docker-compose.yml
Outdated
| @@ -1,7 +1,8 @@ | |||
| version: '2' | |||
| services: | |||
| autopush: | |||
| image: bbangert/autopush | |||
| # image: bbangert/autopush | |||
There was a problem hiding this comment.
I was actually debating if we wanted to make this use the image we generate when we tag a release, rather than doing a local build.
docs/index.rst
Outdated
| @@ -10,6 +10,11 @@ autopush | |||
|
|
|||
| Mozilla Push server and Push Endpoint utilizing PyPy, twisted, rust, and DynamoDB. | |||
* Fix out of date documentation * Fix tests to use new local env var (like we do for endpoint) * Add rust migration document * Fix autokey to return something useful * Point out that docker_compose does bad things to your expectations about CRYPTO_KEY Closes #1260 Issue mozilla-services/autopush-rs#7
| # the previous 'build:' line and uncomment the following | ||
| # 'image:' line. This will use the latest production | ||
| # built image. | ||
| #image: mozilla/autopush |
There was a problem hiding this comment.
I'll note that the current mozilla/autopush image doesn't work with this version of docker-compose, thus the comment for now. Obviously, the most stable thing is to build locally, but if we want folks to just play, we can switch the defaults here.
about CRYPTO_KEY
Closes #1260
Issue mozilla-services/autopush-rs#7