This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: ensure consistent_read on fetch messages fns #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lost this in the python port Issue #1249
pjenvey
added this to the 2018Q2-2.1 Rust connection node with broadcast deployed to Prod milestone
pjenvey
commented
May 22, 2018
| if messages.is_empty() { | ||
| return Ok(Default::default()); | ||
| } | ||
|
|
||
| let timestamp = messages.iter().filter_map(|m| m.sortkey_timestamp).max(); |
There was a problem hiding this comment.
max() gives us None for free here on empty iters
Codecov Report
@@ Coverage Diff @@
## master #1250 +/- ##
=======================================
Coverage 99.99% 99.99%
=======================================
Files 60 60
Lines 10547 10547
=======================================
Hits 10546 10546
Misses 1 1Continue to review full report at Codecov.
|
bbangert
approved these changes
May 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lost this in the python port
Issue #1249