This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
feat: switch from snaek to milksnake #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires a couple workarounds: - rename queue::Sender -> AutopushSender to avoid cbindgen bug w/ type aliases: mozilla/cbindgen#131 - make structs not representable in C opaque (remove #[repr(C)]) - have to pin to an older serde_derive for now because cbindgen does Closes #1045
pjenvey
added this to the 2018Q2-2.1 Rust connection node with broadcast deployed to Prod milestone
pjenvey
commented
May 11, 2018
| - autopush_rs/target | ||
| - $HOME/.cache/pip | ||
| sudo: required | ||
| dist: trusty | ||
|
|
||
| env: | ||
| global: | ||
| - WITH_RUST=release |
There was a problem hiding this comment.
I was hoping to switch travis to rustc debug mode but that enables slog's verbose logging that floods travis w/ 4mb of logs, causing tests to fail (we can revisit this later)
alexcrichton
approved these changes
May 11, 2018
bbangert
approved these changes
May 11, 2018
Codecov Report
@@ Coverage Diff @@
## master #1226 +/- ##
======================================
Coverage 100% 100%
======================================
Files 60 60
Lines 10198 10198
======================================
Hits 10198 10198Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires a couple workarounds:
cbindgen panics during generation #2 mozilla/cbindgen#131
Closes #1045